From 4074c1ef4775f1f45f5de16b1afab77a3d586427 Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Wed, 11 Feb 2026 02:32:38 +0000
Subject: [PATCH] =testing upload manager racing condition for updating an image field to an empty string immediately after successfully setting the image
---
inc/meta/Form.php | 23 ++++++++++++++++-------
1 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/inc/meta/Form.php b/inc/meta/Form.php
index b20fc27..9f568f4 100644
--- a/inc/meta/Form.php
+++ b/inc/meta/Form.php
@@ -745,6 +745,13 @@
}
$input .= '</div>'; // closes .file-upload-container
+
+ $input .= sprintf(
+ '<input type="hidden" name="%s" value="%s">',
+ esc_attr($name),
+ esc_attr(!empty($attachmentIds) ? implode(',', $attachmentIds) : '')
+ );
+
unset($config['description']);
unset($config['label']);
return static::fieldWrap($name, $input, $config);
@@ -1189,7 +1196,10 @@
$input = sprintf(
'<div class="row btw">
- <label for="%s-autocomplete">%s<span>%s</span></label>',
+ <input type="hidden" name="%s" value="%s">
+ <label for="%s-autocomplete">%s<span>%s</span></label>',
+ esc_attr($name),
+ esc_attr(!empty($ids) ? implode(',', $ids) : ''),
esc_attr($name),
jvbIcon($icon),
esc_html($config['label']),
@@ -1202,16 +1212,18 @@
}
$plural = static::getPlural($config);
$input .= sprintf(
- '<div class="selected-item row" role="region" aria-label="Selected %s"></div>',
+ '<div class="selected-items row" role="region" aria-label="Selected %s"></div>',
$plural[1]??''
);
+ $input .= '</div>'; //Close the first div.row.btw
+
$config['type'] = 'selector';
unset($config['label']);
unset($config['description']);
unset($config['hint']);
$config['skipInput'] = true;
- return static::fieldWrap($containerId, $input, $config);
+ return static::fieldWrap($name, $input, $config);
}
protected static function getPlural(array $config):array
@@ -1363,13 +1375,10 @@
}
protected static function buildSelectorAutocomplete(string $name, array $config): string
{
- $containerId = sprintf('%s-%s-selector', $name, $config['subtype'] ?? $config['type']);
return sprintf(
- '<input type="hidden" name="%s" value="">
- <input type="search" id="%s-autocomplete" autocomplete="off" data-ignore data-autocomplete>
+ '<input type="search" id="%s-autocomplete" autocomplete="off" data-ignore data-autocomplete>
<p class="message" hidden aria-live="polite">{ <span>Loading items</span> }</p>
<div class="auto-wrapper" hidden><ul class="search-results"></ul><button class="submit-term" hidden data-ignore><strong>Create: </strong> "<span></span>"</button></div>',
- esc_attr($containerId),
esc_attr($name)
);
}
--
Gitblit v1.10.0