From 607a0c1c65629e883859f0d17d79ced334ddec4c Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Tue, 10 Feb 2026 21:12:09 +0000
Subject: [PATCH] =Taxonomy autocomplete fixes?
---
inc/meta/Form.php | 58 +++++++++++++++++++++++++++++++++++++++-------------------
1 files changed, 39 insertions(+), 19 deletions(-)
diff --git a/inc/meta/Form.php b/inc/meta/Form.php
index 2ad8dc9..ed48047 100644
--- a/inc/meta/Form.php
+++ b/inc/meta/Form.php
@@ -107,6 +107,8 @@
$output .= static::buildLabel($name, $config);
if (!array_key_exists('skipInput', $config)) {
$output .= static::buildInput($content);
+ } else {
+ $output .= $content;
}
$output .= static::buildHint($config);
@@ -570,30 +572,47 @@
protected static function renderRadio(string $name, mixed $value, array $config): string
{
- $options = $config['options'] ?? [];
+ $options = $config['options'] ?? [];
+ $inputClass = !empty($config['inputClass']) ? ' class="' . esc_attr($config['inputClass']) . '"' : '';
+ $idPrefix = $config['idPrefix'] ?? '';
$radios = sprintf(
'<fieldset>
- <legend>%s%s</legend>',
+ <legend>%s%s</legend>',
array_key_exists('label', $config) ? esc_html($config['label']) : 'Select an option',
- array_key_exists('required', $config) && $config['required']===true ? '<span class="required" aria-label="required">*</span>' : ''
+ array_key_exists('required', $config) && $config['required'] === true
+ ? '<span class="required" aria-label="required">*</span>' : ''
);
- foreach ($options as $optValue => $optLabel) {
+ foreach ($options as $optValue => $optConfig) {
+ if (is_array($optConfig)) {
+ $optLabel = $optConfig['label'] ?? $optValue;
+ $optIcon = $optConfig['icon'] ?? null;
+ $optDisabled = !empty($optConfig['disabled']) ? ' disabled' : '';
+ } else {
+ $optLabel = $optConfig;
+ $optIcon = null;
+ $optDisabled = '';
+ }
+
+ $labelContent = $optIcon
+ ? jvbDashIcon($optIcon)
+ : '<span>' . esc_html($optLabel) . '</span>';
+
+ $optId = esc_attr($idPrefix . $name . '-' . $optValue);
+
$radios .= sprintf(
- '
- <input type="radio" name="%s" id="%s-%s" value="%s"%s />
- <label class="radio-option" for="%s-%s">
- <span>%s</span>
- </label>',
+ '<input type="radio" name="%s" id="%s" value="%s"%s%s%s />
+ <label class="radio-option" for="%s" title="%s">%s</label>',
esc_attr($name),
- esc_attr($name),
- $optValue,
+ $optId,
esc_attr($optValue),
- checked($value, $optValue,false),
- esc_attr($name),
- $optValue,
- esc_html($optLabel)
+ checked($value, $optValue, false),
+ $optDisabled,
+ $inputClass,
+ $optId,
+ esc_html($optLabel),
+ $labelContent
);
}
@@ -1187,6 +1206,7 @@
$plural[1]??''
);
+ $config['type'] = 'selector';
unset($config['label']);
unset($config['description']);
unset($config['hint']);
@@ -1257,7 +1277,7 @@
$plural = $taxonomy->labels->name;
}
$attr = sprintf(
- ' data-taxonomy="%s" data-single="%s" data-plural="%s',
+ ' data-taxonomy="%s" data-single="%s" data-plural="%s"',
$config['taxonomy'],
$single,
$plural
@@ -1276,7 +1296,7 @@
$plural = $postType->labels->name;
}
$attr = sprintf(
- ' data-content="%s" data-single="%s" data-plural="%s',
+ ' data-content="%s" data-single="%s" data-plural="%s"',
$config['content'],
$single,
$plural
@@ -1296,7 +1316,7 @@
$plural = 'Users';
}
$attr = sprintf(
- ' data-user="%s" data-single="%s" data-plural="%s',
+ ' data-user="%s" data-single="%s" data-plural="%s"',
$config['user'],
$single,
$plural
@@ -1344,7 +1364,7 @@
protected static function buildSelectorAutocomplete(string $name, array $config):string
{
return sprintf(
- '<input type="hidden" id="%s-autocomplete" autocomplete="off" data-ignore data-autocomplete>
+ '<input type="search" id="%s-autocomplete" autocomplete="off" data-ignore data-autocomplete>
<p class="message" hidden aria-live="polite">{ <span>Loading items</span> }</p>
<div class="auto-wrapper" hidden><ul class="search-results"></ul><button class="submit-term" hidden data-ignore><strong>Create: </strong> "<span></span>"</button></div>',
$name
--
Gitblit v1.10.0