From 772462eeca3002a1d52508aeba485aab2b4742ad Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Tue, 03 Mar 2026 19:06:19 +0000
Subject: [PATCH] =MAJOR OVERHAUL. Likely should have made a new branch ages ago. Key changes: Registrar.php is the base for custom post types, taxonomies, and user roles. Replaces JVB_CONTENT, JVB_TAXONOMY, and JVB_USER constants, eliminates most of Features.php (except for JVB_SITE, JVB_MEMBERSHIP), and has built in sanitizing and validation via sub-classes. Also started a major overhaul of the Schema output. Created a shit ton of property traits and classes to help sanitize and ensure proper data for different schema types. Still a bunch to do, but better to be starting committing changes here on this other branch.

---
 inc/rest/routes/ApprovalRoutes.php |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/inc/rest/routes/ApprovalRoutes.php b/inc/rest/routes/ApprovalRoutes.php
index 6f9d590..d955825 100644
--- a/inc/rest/routes/ApprovalRoutes.php
+++ b/inc/rest/routes/ApprovalRoutes.php
@@ -3,6 +3,7 @@
 namespace JVBase\rest\routes;
 
 use JVBase\managers\CustomTable;
+use JVBase\registrar\Registrar;
 use JVBase\rest\PermissionHandler;
 use JVBase\rest\Rest;
 use JVBase\rest\Route;
@@ -42,20 +43,14 @@
 
     protected function initTypes():void
     {
-        $approvals = jvbApprovalTypes();
         $this->userTypes = [];
         $this->termTypes = [];
         if ($this->hasMemberApproval) {
-            $this->userTypes = array_filter(
-                array_keys($approvals),
-                function ($item) {
-                    return $item !== 'term';
-                }
-            );
+            $this->userTypes = Registrar::getFeatured('approve_new', 'user');
             $this->allTypes = $this->userTypes;
         }
-        if (jvbSiteHasTermApproval()) {
-            $this->termTypes = $approvals['term']??[];
+        if (Features::forSite()->has('term_approval')) {
+            $this->termTypes = Registrar::getFeatured('approve_new', 'term');
             $this->allTypes[] = 'term';
         }
     }

--
Gitblit v1.10.0