From a9654f00c8fbc9934289d761843ddd071025013f Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Fri, 28 Aug 2026 17:20:28 +0000
Subject: [PATCH] =PHPStorm Code Inspection: fixed class reference errors (from getting rid of JVB() and replacing with direct class::getInstance; as well as general code sniffing, etc
---
inc/managers/AdminPages.php | 15 +++++----------
1 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/inc/managers/AdminPages.php b/inc/managers/AdminPages.php
index 4f0056c..c7b2062 100644
--- a/inc/managers/AdminPages.php
+++ b/inc/managers/AdminPages.php
@@ -2,8 +2,8 @@
namespace JVBase\managers;
use JVBase\Instance;
+use JVBase\managers\queue\Queue;
use JVBase\registrar\Registrar;
-use JVBase\base\Site;
use WP_REST_Response;
if (!defined('ABSPATH')) {
@@ -453,7 +453,7 @@
public function enqueueAdminAssets(string $hook):void
{
// More robust check for JVB admin pages
- if (strpos($hook, BASE) === false) {
+ if (!str_contains($hook, BASE)) {
return;
}
@@ -610,12 +610,7 @@
$group = jvbNoBase($group);
$registered = Registrar::getRegistered();
- foreach ($registered as $r) {
- if ($r === $group) {
- return true;
- }
- }
- return false;
+ return in_array($group, $registered, true);
}
protected function formatConnections(array $data): string
@@ -740,7 +735,7 @@
<?php if (empty($versions)): ?>
<tr><td colspan="5">No version history available</td></tr>
<?php else: ?>
- <?php foreach (array_reverse($versions) as $index => $version): ?>
+ <?php foreach (array_reverse($versions) as $version): ?>
<tr>
<th class="check-column">
<input type="checkbox"
@@ -804,7 +799,7 @@
public function handleAdminPageSubmission(): void
{
// Only process on our admin pages
- if (!isset($_GET['page']) || strpos($_GET['page'], BASE) !== 0) {
+ if (!isset($_GET['page']) || !str_starts_with($_GET['page'], BASE)) {
return;
}
--
Gitblit v1.10.0