From a24a06002081ad71a78ffeff9072725ba39cf121 Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Tue, 17 Feb 2026 20:05:31 +0000
Subject: [PATCH] =minor changes, particularly around the JVB_CHILD_URL pattern
---
inc/meta/Form.php | 46 ++++++++++++++++++++++++++++++----------------
1 files changed, 30 insertions(+), 16 deletions(-)
diff --git a/inc/meta/Form.php b/inc/meta/Form.php
index e5725b0..1d3db3f 100644
--- a/inc/meta/Form.php
+++ b/inc/meta/Form.php
@@ -745,6 +745,13 @@
}
$input .= '</div>'; // closes .file-upload-container
+
+ $input .= sprintf(
+ '<input type="hidden" name="%s" value="%s">',
+ esc_attr($name),
+ esc_attr(!empty($attachmentIds) ? implode(',', $attachmentIds) : '')
+ );
+
unset($config['description']);
unset($config['label']);
return static::fieldWrap($name, $input, $config);
@@ -1189,7 +1196,10 @@
$input = sprintf(
'<div class="row btw">
- <label for="%s-autocomplete">%s<span>%s</span></label>',
+ <input type="hidden" name="%s" value="%s">
+ <label for="%s-autocomplete">%s<span>%s</span></label>',
+ esc_attr($name),
+ esc_attr(!empty($ids) ? implode(',', $ids) : ''),
esc_attr($name),
jvbIcon($icon),
esc_html($config['label']),
@@ -1202,15 +1212,18 @@
}
$plural = static::getPlural($config);
$input .= sprintf(
- '<div class="selected-item row" role="region" aria-label="Selected %s"></div>',
+ '<div class="selected-items row" role="region" aria-label="Selected %s"></div>',
$plural[1]??''
);
+ $input .= '</div>'; //Close the first div.row.btw
+
+ $config['type'] = 'selector';
unset($config['label']);
unset($config['description']);
unset($config['hint']);
$config['skipInput'] = true;
- return static::fieldWrap($containerId, $input, $config);
+ return static::fieldWrap($name, $input, $config);
}
protected static function getPlural(array $config):array
@@ -1276,7 +1289,7 @@
$plural = $taxonomy->labels->name;
}
$attr = sprintf(
- ' data-taxonomy="%s" data-single="%s" data-plural="%s',
+ ' data-taxonomy="%s" data-single="%s" data-plural="%s"',
$config['taxonomy'],
$single,
$plural
@@ -1295,7 +1308,7 @@
$plural = $postType->labels->name;
}
$attr = sprintf(
- ' data-content="%s" data-single="%s" data-plural="%s',
+ ' data-content="%s" data-single="%s" data-plural="%s"',
$config['content'],
$single,
$plural
@@ -1315,7 +1328,7 @@
$plural = 'Users';
}
$attr = sprintf(
- ' data-user="%s" data-single="%s" data-plural="%s',
+ ' data-user="%s" data-single="%s" data-plural="%s"',
$config['user'],
$single,
$plural
@@ -1343,7 +1356,7 @@
$dataAttrs[] = 'data-selected="'.esc_attr(implode(',',$selected)).'"';
}
if ($config['autocomplete']) {
- $dataAttrs[] = 'autocomplete';
+ $dataAttrs[] = 'data-autocomplete';
}
if (array_key_exists('hidden', $config) && $config['hidden']) {
$dataAttrs[] = 'hidden';
@@ -1360,15 +1373,15 @@
jvbIcon('plus-square')
);
}
- protected static function buildSelectorAutocomplete(string $name, array $config):string
- {
- return sprintf(
- '<input type="hidden" id="%s-autocomplete" autocomplete="off" data-ignore data-autocomplete>
- <p class="message" hidden aria-live="polite">{ <span>Loading items</span> }</p>
- <div class="auto-wrapper" hidden><ul class="search-results"></ul><button class="submit-term" hidden data-ignore><strong>Create: </strong> "<span></span>"</button></div>',
- $name
- );
- }
+ protected static function buildSelectorAutocomplete(string $name, array $config): string
+ {
+ return sprintf(
+ '<input type="search" id="%s-autocomplete" autocomplete="off" data-ignore data-autocomplete>
+ <p class="message" hidden aria-live="polite">{ <span>Loading items</span> }</p>
+ <div class="auto-wrapper" hidden><ul class="search-results"></ul><button class="submit-term" hidden data-ignore><strong>Create: </strong> "<span></span>"</button></div>',
+ esc_attr($name)
+ );
+ }
protected static function renderTaxonomy(string $name, mixed $value, array $config): string
{
@@ -1613,6 +1626,7 @@
array_key_exists('add_label', $config) ? $config['add_label'] : 'Add Item'
);
+ unset($config['label']);
return static::fieldWrap($name, $input, $config);
}
protected static function renderRepeaterRow(array $fields, array $values, int|string $index, string $name, string $rowTitle='New Item'):string
--
Gitblit v1.10.0